refactor!: dynamically load releasers in ./releasers directory #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #439 +/- ##
===========================================
- Coverage 89.51% 79.51% -10.00%
===========================================
Files 32 40 +8
Lines 3643 4487 +844
Branches 314 334 +20
===========================================
+ Hits 3261 3568 +307
- Misses 381 918 +537
Partials 1 1
Continue to review full report at Codecov.
|
alexander-fenster
approved these changes
May 19, 2020
bcoe
changed the title
bcoe
added
the
kokoro:force-run
src/releasers/index.ts
Outdated
|
|
||
| export function getReleaserNames(): string[] { | ||
| return releasers.map(releaser => { | ||
| console.info(releaser.releaserName); |
There was a problem hiding this comment.
do we still need this logging?
src/releasers/index.ts
Outdated
| !file.name.match(/index\.js/) | ||
| ) { | ||
| const obj = require(`./${file.name}`) as {[key: string]: typeof ReleasePR}; | ||
| releasers.push(obj[Object.keys(obj)[0]]); |
There was a problem hiding this comment.
nit, I would probably add them to an object instead, so that we could get one by accessing it by name directly and without a for loop. But I'm OK either way.
alexander-fenster
approved these changes
May 19, 2020
yoshi-kokoro
removed
the
kokoro:force-run
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor pulls some additional logic to the
ReleasePRclass (it now hasreleaserNamewhich is used rather than anenumfor looking up a specific release type, andlookupPackageNamemethod, which was a feature being done in an ad hoc way for only Node.js).BREAKING CHANGE: this removers the
ReleaseTypeenum, in favor of a dynamically generated list of loaders.